[
https://issues.apache.org/jira/browse/BEAM-14388?focusedWorklogId=765550&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765550
]
ASF GitHub Bot logged work on BEAM-14388:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/May/22 17:05
Start Date: 03/May/22 17:05
Worklog Time Spent: 10m
Work Description: reuvenlax commented on code in PR #17417:
URL: https://github.com/apache/beam/pull/17417#discussion_r863995882
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java:
##########
@@ -19,12 +19,14 @@
import static
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Preconditions.checkArgument;
+import com.google.api.core.ApiFuture;
import com.google.cloud.bigquery.storage.v1.AppendRowsResponse;
import com.google.cloud.bigquery.storage.v1.ProtoRows;
import com.google.cloud.bigquery.storage.v1.WriteStream.Type;
import com.google.protobuf.ByteString;
import com.google.protobuf.DynamicMessage;
import java.io.IOException;
+import java.time.Instant;
Review Comment:
java Instant is the recommended class to use. We continue using Joda in
public APIs (and in encoded bytes) for backwards compatibility reasons, but for
internal uses like this java time is nicer to use.
Issue Time Tracking
-------------------
Worklog Id: (was: 765550)
Time Spent: 40m (was: 0.5h)
> Performance problems when using Storage API writes
> --------------------------------------------------
>
> Key: BEAM-14388
> URL: https://issues.apache.org/jira/browse/BEAM-14388
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Reuven Lax
> Priority: P2
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
