[jira] [Work logged] (BEAM-14405) Java Spanner IO NPE when ProjectID not specified in template executions

Wed, 04 May 2022 01:38:31 -0700 


     [ 
https://issues.apache.org/jira/browse/BEAM-14405?focusedWorklogId=765868&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765868
 ]

ASF GitHub Bot logged work on BEAM-14405:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/May/22 08:37
            Start Date: 04/May/22 08:37
    Worklog Time Spent: 10m 
      Work Description: nielm opened a new pull request, #17540:
URL: https://github.com/apache/beam/pull/17540

   PR #16547 added handling for null ProjectIDs on command line execution,
   but did not handle the possibility of null ProjectIDs in template
   execution. PR #17094 added nullness checks in MonitoringInfoMetricNames,
   which then triggered NPEs if the ProjectID was not specified during a
   template execution.
   
   This corrects this by checking for a null ValueProvider, as well as a null 
value in the ValueProvider.
   
   ------------------------
   
   GitHub Actions Tests Status (on master branch)
   
------------------------------------------------------------------------------------------------
   [![Build python source distribution and 
wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python 
tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java 
tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more 
information about GitHub Actions CI.
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 765868)
    Remaining Estimate: 0h
            Time Spent: 10m

> Java Spanner IO NPE when ProjectID not specified in template executions
> -----------------------------------------------------------------------
>
>                 Key: BEAM-14405
>                 URL: https://issues.apache.org/jira/browse/BEAM-14405
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-gcp
>    Affects Versions: 2.38.0
>            Reporter: Niel Markwick
>            Assignee: Niel Markwick
>            Priority: P1
>             Fix For: 2.39.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> BEAM-13665 fixed the issue of NPE's when ProjectIDs were not specified in 
> command line executions by checking for a null ValueProvider, but in 
> _template_ executions, the ValueProvider is non-null but has a null 
> {_}value{_}. 
> [PR #17094|https://github.com/apache/beam/pull/17094] from BEAM-14116 added 
> nullness checks for keys in MonitoringInfoMetricName, which then triggered 
> the NPE in 2.38.0 when a template was executed with an unspecified ProjectID.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to