[
https://issues.apache.org/jira/browse/BEAM-14303?focusedWorklogId=766198&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-766198
]
ASF GitHub Bot logged work on BEAM-14303:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/22 17:58
Start Date: 04/May/22 17:58
Worklog Time Spent: 10m
Work Description: chamikaramj commented on code in PR #17359:
URL: https://github.com/apache/beam/pull/17359#discussion_r865121914
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java:
##########
@@ -1216,6 +1219,14 @@ private Instant minTargetAndGcTime(Instant target) {
@Override
public Timer withOutputTimestamp(Instant outputTimestamp) {
this.outputTimestamp = outputTimestamp;
+ this.noOutputTimestamp = false;
+ return this;
+ }
+
+ @Override
+ public Timer withNoOutputTimestamp() {
Review Comment:
Please add a test for this.
Issue Time Tracking
-------------------
Worklog Id: (was: 766198)
Time Spent: 4h 40m (was: 4.5h)
> Allow a timer to have no watermark hold
> ---------------------------------------
>
> Key: BEAM-14303
> URL: https://issues.apache.org/jira/browse/BEAM-14303
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: P2
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
