[
https://issues.apache.org/jira/browse/BEAM-1754?focusedWorklogId=766265&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-766265
]
ASF GitHub Bot logged work on BEAM-1754:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/22 20:32
Start Date: 04/May/22 20:32
Worklog Time Spent: 10m
Work Description: robertwb commented on code in PR #17341:
URL: https://github.com/apache/beam/pull/17341#discussion_r865340404
##########
sdks/typescript/test/serialize_test.ts:
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { expect } from "chai";
+import {
+ deserialize,
+ serialize,
+ BuiltinList,
+ generateDefaultBuiltins,
+} from "serialize-closures";
+
+describe("serialization tests", function () {
+ function roundtrip(value, builtins?: BuiltinList) {
+ return deserialize(
+ JSON.parse(JSON.stringify(serialize(value, builtins))),
+ builtins
+ );
+ }
+
+ function expectRoundtrip(value, builtins?: BuiltinList) {
+ expect(roundtrip(value, builtins)).to.deep.equal(value);
+ }
+
+ function* myGenerator() {
+ yield 42;
+ yield 84;
+ }
+
+ function simpleGenerator() {
+ expect(myGenerator().next()).to.equal(42);
+ }
+
+ function roundtripGeneratorConstructor() {
+ expect(roundtrip(myGenerator)().next()).to.equal(42);
+ }
+
+ function roundtripGeneratorInProgress() {
Review Comment:
Updated this file to run tests of our actual serialization.
Issue Time Tracking
-------------------
Worklog Id: (was: 766265)
Time Spent: 6h 10m (was: 6h)
> Will Dataflow ever support Node.js with an SDK similar to Java or Python?
> -------------------------------------------------------------------------
>
> Key: BEAM-1754
> URL: https://issues.apache.org/jira/browse/BEAM-1754
> Project: Beam
> Issue Type: New Feature
> Components: sdk-ideas
> Reporter: Diego Zuluaga
> Assignee: Kerry Donny-Clark
> Priority: P3
> Labels: node.js
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> I like the philosophy behind DataFlow and found the Java and Python samples
> highly comprehensible. However, I have to admit that for most Node.js
> developers who have little background on typed languages and are used to get
> up to speed with frameworks incredibly fast, learning Dataflow might take
> some learning curve that they/we're not used to. So, I wonder if at any point
> in time Dataflow will provide a Node.js SDK. Maybe this is out of the
> question, but I wanted to run it by the team as it would be awesome to have
> something along these lines!
> Thanks,
> Diego
> Question originaly posted in SO:
> http://stackoverflow.com/questions/42893436/will-dataflow-ever-support-node-js-with-and-sdk-similar-to-java-or-python
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
