[
https://issues.apache.org/jira/browse/BEAM-6853?focusedWorklogId=227975&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-227975
]
ASF GitHub Bot logged work on BEAM-6853:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Apr/19 21:22
Start Date: 15/Apr/19 21:22
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8286: [BEAM-6853]
Make sdkWorkerParallelism option consistent
URL: https://github.com/apache/beam/pull/8286#discussion_r275545246
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/jobsubmission/JobServerDriver.java
##########
@@ -96,8 +96,11 @@ protected InMemoryJobService createJobService() throws
IOException {
@Option(
name = "--sdk-worker-parallelism",
- usage = "Default parallelism for SDK worker processes (see portable
pipeline options)")
- private Long sdkWorkerParallelism = 1L;
+ usage =
+ "Default parallelism for SDK worker processes (see portable
pipeline options). "
Review comment:
Consider slightly different order: `Parallelism level for SDK worker
processes.
This value is used only when the pipeline option sdkWorkerParallelism is set
to 0, otherwise the value provided in pipeline options takes precedence.
Default is 0, which means worker parallelism will be dynamically decided by a
runner. See also: sdkWorkerParallelism Pipeline Option`. Also, should last
sentence be a Javadoc reference?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 227975)
Time Spent: 2h 10m (was: 2h)
> Make Java and python portable options same
> ------------------------------------------
>
> Key: BEAM-6853
> URL: https://issues.apache.org/jira/browse/BEAM-6853
> Project: Beam
> Issue Type: Task
> Components: sdk-py-core
> Reporter: Ankur Goenka
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Java
> [PortableRunnerOptions|https://github.com/apache/beam/blob/f21cfaefd54afb798103dc90ab57290739e81e81/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PortablePipelineOptions.java#L80]
> and [Python Portable
> options|https://github.com/apache/beam/blob/f21cfaefd54afb798103dc90ab57290739e81e81/sdks/python/apache_beam/options/pipeline_options.py#L719]
> don't have the same values limiting the use of sdk-worker-parallelism and
> environment-cache-millis in python sdk.
>
> Add these options to the python sdk.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
