[
https://issues.apache.org/jira/browse/BEAM-14432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Damian updated BEAM-14432:
--------------------------
Description:
[WriteWithResult|#L1551] in
[JdbcIO|[https://github.com/apache/beam/blob/master/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java]]
works in different way than expected. Difference lies in implementation of
approach to row mappers in WriteFn and way how
[processRecord|#L2407-L2423]]method works. Current implementation left for
developer responsibility for processing returned ResultSet from write operation
when result can be empty, one or many. Instead result should be iterated when
next value is available, like for [ReadFn|#L1370-L1373]]. Issue exists since
improvement: https://issues.apache.org/jira/browse/BEAM-11873
In the attachment diff with possible solution.
was:
[WriteWithResult|#L1551]] in
[JdbcIO|[https://github.com/apache/beam/blob/master/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java]]
works in different way than expected. Difference lies in implementation of
approach to row mappers in WriteFn and way how
[processRecord|#L2407-L2423]]method works. Current implementation left for
developer responsibility for processing returned ResultSet from write operation
when result can be empty, one or many. Instead result should be iterated when
next value is available, like for [ReadFn|#L1370-L1373]]. Issue exists since
improvement: https://issues.apache.org/jira/browse/BEAM-11873
In the attachment diff with possible solution.
> JdbcIO: WriteWithResult not works as expected when maps ResultSet
> -----------------------------------------------------------------
>
> Key: BEAM-14432
> URL: https://issues.apache.org/jira/browse/BEAM-14432
> Project: Beam
> Issue Type: Bug
> Components: io-java-jdbc
> Affects Versions: 2.34.0, 2.35.0, 2.36.0, 2.37.0, 2.38.0
> Reporter: Damian
> Priority: P2
> Attachments: SolutionProposal.png
>
>
> [WriteWithResult|#L1551] in
> [JdbcIO|[https://github.com/apache/beam/blob/master/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java]]
> works in different way than expected. Difference lies in implementation of
> approach to row mappers in WriteFn and way how
> [processRecord|#L2407-L2423]]method works. Current implementation left for
> developer responsibility for processing returned ResultSet from write
> operation when result can be empty, one or many. Instead result should be
> iterated when next value is available, like for [ReadFn|#L1370-L1373]]. Issue
> exists since improvement: https://issues.apache.org/jira/browse/BEAM-11873
> In the attachment diff with possible solution.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
