[
https://issues.apache.org/jira/browse/BEAM-13988?focusedWorklogId=767390&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-767390
]
ASF GitHub Bot logged work on BEAM-13988:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/May/22 19:28
Start Date: 06/May/22 19:28
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on PR #17578:
URL: https://github.com/apache/beam/pull/17578#issuecomment-1119948039
#
[Codecov](https://codecov.io/gh/apache/beam/pull/17578?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#17578](https://codecov.io/gh/apache/beam/pull/17578?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(37f64e2) into
[master](https://codecov.io/gh/apache/beam/commit/a0684f502f01027644a5c0f5fdc7454cb2799290?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(a0684f5) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #17578 +/- ##
==========================================
- Coverage 73.93% 73.93% -0.01%
==========================================
Files 691 691
Lines 91562 91560 -2
==========================================
- Hits 67700 67698 -2
Misses 22629 22629
Partials 1233 1233
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `50.19% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
to find out more.
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/17578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/go/pkg/beam/core/graph/mtime/time.go](https://codecov.io/gh/apache/beam/pull/17578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL2dyYXBoL210aW1lL3RpbWUuZ28=)
| `52.63% <100.00%> (-2.37%)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/17578?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/17578?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[a0684f5...37f64e2](https://codecov.io/gh/apache/beam/pull/17578?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Issue Time Tracking
-------------------
Worklog Id: (was: 767390)
Time Spent: 40m (was: 0.5h)
> Update mtime package to use time.UnixMilli()
> --------------------------------------------
>
> Key: BEAM-13988
> URL: https://issues.apache.org/jira/browse/BEAM-13988
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Jack McCluskey
> Priority: P3
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Update the `mtime` package's [FromTime()
> function|https://github.com/apache/beam/blob/5345834a86c422347556e0bce7e5dd20e4854e44/sdks/go/pkg/beam/core/graph/mtime/time.go#L67]
> to use the `time` package's [UnixMilli()
> function|https://pkg.go.dev/time#UnixMilli] instead of doing the unit
> conversion from nanoseconds to milliseconds once the minimum Go version for
> the Beam Go SDK is at or above 1.17.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
