[
https://issues.apache.org/jira/browse/BEAM-14229?focusedWorklogId=767453&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-767453
]
ASF GitHub Bot logged work on BEAM-14229:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/May/22 23:04
Start Date: 06/May/22 23:04
Worklog Time Spent: 10m
Work Description: y1chi opened a new pull request, #17583:
URL: https://github.com/apache/beam/pull/17583
It appears that the there could be multiple UnboundedSourceAsSDFWrapperFns
creating RestrictionTrackers for same restriction. This led to duplicate
records being produce because each UnboundedSourceAsSDFWrapperFn have separate
reader cache, and each UnboundedSourceAsSDFWrapperFn will create new
UnboundedSourceReader separately when not initialized.
Making source reader cache global so that the reader could be effectively
checked out and this avoid duplication of same source readers.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
Issue Time Tracking
-------------------
Worklog Id: (was: 767453)
Remaining Estimate: 0h
Time Spent: 10m
> Correctly comment or remove Metrics Cache
> -----------------------------------------
>
> Key: BEAM-14229
> URL: https://issues.apache.org/jira/browse/BEAM-14229
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Ryan Thompson
> Assignee: Ryan Thompson
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The base RunInference metrics collector has a cache for metrics loaded during
> setup.
>
> Either comment why it is necessary or remove it.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
