[
https://issues.apache.org/jira/browse/BEAM-14447?focusedWorklogId=768604&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-768604
]
ASF GitHub Bot logged work on BEAM-14447:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/May/22 17:14
Start Date: 10/May/22 17:14
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on PR #17601:
URL: https://github.com/apache/beam/pull/17601#issuecomment-1122661809
#
[Codecov](https://codecov.io/gh/apache/beam/pull/17601?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#17601](https://codecov.io/gh/apache/beam/pull/17601?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(abf488e) into
[master](https://codecov.io/gh/apache/beam/commit/5c21fbccec5e1e831dd0040bd7f631c050865430?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(5c21fbc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #17601 +/- ##
==========================================
- Coverage 73.96% 73.95% -0.02%
==========================================
Files 693 693
Lines 91716 91716
==========================================
- Hits 67837 67826 -11
- Misses 22630 22641 +11
Partials 1249 1249
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.70% <100.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
to find out more.
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/17601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/17601/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5)
| `63.98% <100.00%> (+0.11%)` | :arrow_up: |
|
[.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/17601/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5)
| `88.09% <0.00%> (-4.77%)` | :arrow_down: |
|
[...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/17601/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==)
| `78.26% <0.00%> (-1.45%)` | :arrow_down: |
|
[...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/17601/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=)
| `89.20% <0.00%> (-1.44%)` | :arrow_down: |
|
[...eam/runners/portability/fn\_api\_runner/execution.py](https://codecov.io/gh/apache/beam/pull/17601/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2V4ZWN1dGlvbi5weQ==)
| `92.44% <0.00%> (-0.65%)` | :arrow_down: |
|
[sdks/python/apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/17601/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=)
| `93.05% <0.00%> (-0.39%)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/17601?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/17601?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[5c21fbc...abf488e](https://codecov.io/gh/apache/beam/pull/17601?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Issue Time Tracking
-------------------
Worklog Id: (was: 768604)
Time Spent: 40m (was: 0.5h)
> BigQueryWriteIntegrationTests.test_big_query_write_insert_errors_reporting
> failing in Python PostCommit
> -------------------------------------------------------------------------------------------------------
>
> Key: BEAM-14447
> URL: https://issues.apache.org/jira/browse/BEAM-14447
> Project: Beam
> Issue Type: Bug
> Components: io-py-gcp, test-failures
> Reporter: Brian Hulette
> Priority: P1
> Time Spent: 40m
> Remaining Estimate: 0h
>
> A new test added in [https://github.com/apache/beam/pull/17517] is failing at
> HEAD.
>
> [https://ci-beam.apache.org/job/beam_PostCommit_Python37/5198/testReport/junit/apache_beam.io.gcp.bigquery_write_it_test/BigQueryWriteIntegrationTests/test_big_query_write_insert_errors_reporting/]
>
> {code:java}
> pipeline_verifiers = [
> BigqueryFullResultMatcher(
> project=self.project,
> query="SELECT number, str FROM %s" % table_id,
> data=[(1, 'some_string')]),
> BigqueryFullResultMatcher(
> project=self.project,
> query="SELECT table, reason, row_json FROM %s" %
> errors_table_id,
> data=
> [(
> table_id,
> '[{"reason": "invalid", "location": "", "debugInfo": "", \
> "message": "Missing required field: Msg_0_CLOUD_QUERY_TABLE.str."}]',
> '{"number": 2}'),
> (
> table_id,
> '[{"reason": "invalid", "location":
> "additional_field_str", \
> "debugInfo": "", "message": "no such field: additional_field_str."}]',
> '{"number": 3, "str": "some_string",
> "additional_field_str": \
> "some_string"}')])
> ]
>
> args = self.test_pipeline.get_full_options_as_args(
> on_success_matcher=hc.all_of(*pipeline_verifiers))
>
> with beam.Pipeline(argv=args) as p:
> # pylint: disable=expression-not-assigned
> errors = (
> p | 'create' >> beam.Create(input_data)
> | 'write' >> beam.io.WriteToBigQuery(
> table_id,
> schema=table_schema,
>
> create_disposition=beam.io.BigQueryDisposition.CREATE_IF_NEEDED,
> write_disposition=beam.io.BigQueryDisposition.WRITE_EMPTY))
> (
> errors["FailedRows"]
> | 'ParseErrors' >> beam.Map(
> lambda err: {
> "table": err[0],
> "reason": json.dumps(err[2]),
> "row_json": json.dumps(err[1])
> })
> > | 'WriteErrors' >> beam.io.WriteToBigQuery(
> errors_table_id,
> schema=errors_table_schema,
>
> create_disposition=beam.io.BigQueryDisposition.CREATE_IF_NEEDED,
> write_disposition=beam.io.BigQueryDisposition.WRITE_EMPTY))
> E KeyError: 'FailedRows'
> apache_beam/io/gcp/bigquery_write_it_test.py:461: KeyError {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
