[
https://issues.apache.org/jira/browse/BEAM-14334?focusedWorklogId=768899&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-768899
]
ASF GitHub Bot logged work on BEAM-14334:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/May/22 08:35
Start Date: 11/May/22 08:35
Worklog Time Spent: 10m
Work Description: mosche commented on code in PR #17406:
URL: https://github.com/apache/beam/pull/17406#discussion_r870024622
##########
runners/spark/src/test/java/org/apache/beam/runners/spark/translation/streaming/SparkCoGroupByKeyStreamingTest.java:
##########
@@ -53,8 +52,6 @@ public class SparkCoGroupByKeyStreamingTest {
private static final TupleTag<Integer> INPUT1_TAG = new TupleTag<>("input1");
private static final TupleTag<Integer> INPUT2_TAG = new TupleTag<>("input2");
- @Rule public final transient ReuseSparkContextRule noContextResue =
ReuseSparkContextRule.no();
-
Review Comment:
as said
##########
runners/spark/src/test/java/org/apache/beam/runners/spark/translation/streaming/CreateStreamTest.java:
##########
@@ -86,7 +85,6 @@
public class CreateStreamTest implements Serializable {
@Rule public final transient TestPipeline p = TestPipeline.create();
- @Rule public final transient ReuseSparkContextRule noContextResue =
ReuseSparkContextRule.no();
Review Comment:
as said
Issue Time Tracking
-------------------
Worklog Id: (was: 768899)
Time Spent: 3h 40m (was: 3.5h)
> Avoid using forkEvery in Spark runner tests
> -------------------------------------------
>
> Key: BEAM-14334
> URL: https://issues.apache.org/jira/browse/BEAM-14334
> Project: Beam
> Issue Type: Improvement
> Components: runner-spark, testing
> Reporter: Moritz Mack
> Assignee: Moritz Mack
> Priority: P2
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Usage of *{color:#FF0000}forkEvery 1{color}* is typically a strong sign of
> poor quality / bad code and should be avoided:
> * It significantly impacts performance when running tests.
> * And it often hides resource leaks, either in code or worse in the runner
> itself.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
