[ 
https://issues.apache.org/jira/browse/BEAM-14415?focusedWorklogId=769343&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-769343
 ]

ASF GitHub Bot logged work on BEAM-14415:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/May/22 22:47
            Start Date: 11/May/22 22:47
    Worklog Time Spent: 10m 
      Work Description: TheNeuralBit commented on code in PR #17544:
URL: https://github.com/apache/beam/pull/17544#discussion_r870811522


##########
sdks/python/apache_beam/io/gcp/bigquery_test.py:
##########
@@ -833,6 +838,264 @@ def noop(table, **kwargs):
               test_client=client))
 
 
+class BigQueryStreamingInsertsErrorHandling(unittest.TestCase):

Review Comment:
   I think this suite should be skipped if bigquery fails to import, like the 
other suites in this file. Unfortunately I think that even with that, this test 
will break without GCP dependencies, since the test is parameterized by objects 
in `google.api.core.exceptions`.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 769343)
    Time Spent: 3h 40m  (was: 3.5h)

> WriteToBigQuery with STREAMING_INSERTS needs exception handling tests
> ---------------------------------------------------------------------
>
>                 Key: BEAM-14415
>                 URL: https://issues.apache.org/jira/browse/BEAM-14415
>             Project: Beam
>          Issue Type: Bug
>          Components: io-py-gcp
>            Reporter: Pablo Estrada
>            Priority: P2
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> To make sure that we're dealing with exceptions appropriately, we need to 
> show in tests that the behavior is the appropriate.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to