[
https://issues.apache.org/jira/browse/BEAM-14166?focusedWorklogId=769760&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-769760
]
ASF GitHub Bot logged work on BEAM-14166:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/May/22 16:51
Start Date: 12/May/22 16:51
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on code in PR #17172:
URL: https://github.com/apache/beam/pull/17172#discussion_r871608539
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/FieldValueGetter.java:
##########
@@ -33,5 +33,9 @@
@Nullable
ValueT get(ObjectT object);
+ default @Nullable Object getRaw(ObjectT object) {
Review Comment:
Yeah that makes sense, thanks. Could you add some of this context in a
comment there?
Issue Time Tracking
-------------------
Worklog Id: (was: 769760)
Time Spent: 3h 20m (was: 3h 10m)
> Improvements to RowWithGetter
> -----------------------------
>
> Key: BEAM-14166
> URL: https://issues.apache.org/jira/browse/BEAM-14166
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Moritz Mack
> Assignee: Moritz Mack
> Priority: P2
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Various improvements to getValue(fieldIdx) in RowWithGetters mentioned
> [here|[https://github.com/apache/beam/pull/16947#discussion_r833602836]:]
> * Minimize memory overhead of cache using either a index lookup (array) or a
> single hash map if number of fields exceeds the initial hashmap capacity
> * The cache should be checked before calling a getter to avoid any
> potentially unnecessary conversion in the getter itself.
> * [Nested
> rows|https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java#L111]
> should be cached, otherwise the cache of such nested rows can't be leveraged.
> * Handling of collections / maps / iterables can be significantly improved
> by simply skipping the transform in all cases where {{getValue}} for members
> is the [identity
> transform|https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java#L142].
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
