[
https://issues.apache.org/jira/browse/BEAM-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537524#comment-17537524
]
Valentyn Tymofieiev commented on BEAM-14467:
--------------------------------------------
Relevant files:
https://github.com/apache/beam/blob/master/.github/workflows/python_tests.yml
https://github.com/apache/beam/blob/master/sdks/python/scripts/run_pytest.sh
Perhaps first step is to check which error code we get here:
https://github.com/apache/beam/blob/5064cc247ba3ec2697cd7493b14cef8567d614f6/sdks/python/scripts/run_pytest.sh#L42-L44
Perhaps fist
> Failed test annotated with no_xdist passes github action python test
> --------------------------------------------------------------------
>
> Key: BEAM-14467
> URL: https://issues.apache.org/jira/browse/BEAM-14467
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Yi Hu
> Priority: P1
>
> A python unit test annotated with @pytest.mark.no_xdist does not cause GIthub
> Action check fails even though the test fails. See
> https://github.com/apache/beam/pull/17649 for example. The test is executed
> and failed which can be seen in log.
> {code}
> def test_expected_failure(self):
> > assert False
> E AssertionError: assert False
> apache_beam/pvalue_test.py:56: AssertionError
> - generated xml file:
> /home/runner/work/beam/beam/sdks/python/pytest_py37_no_xdist.xml -
> ====== 1 failed, 71 passed, 12 skipped, 5389 deselected in 11.71 seconds
> =======
> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
