[
https://issues.apache.org/jira/browse/BEAM-14474?focusedWorklogId=771034&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-771034
]
ASF GitHub Bot logged work on BEAM-14474:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/May/22 20:57
Start Date: 16/May/22 20:57
Worklog Time Spent: 10m
Work Description: Abacn commented on code in PR #17682:
URL: https://github.com/apache/beam/pull/17682#discussion_r874150664
##########
sdks/python/apache_beam/dataframe/frames_test.py:
##########
@@ -1723,28 +1729,24 @@ def test_groupby_callable(self):
def test_groupby_apply(self):
df = GROUPBY_DF
-
- def median_sum_fn(x):
- return (x.foo + x.bar).median()
-
Review Comment:
Yeah I agree with the idea. Given the amount of code added I considered pick
up them into a separate helper function. Nevertheless it is still in the
GroupByTest test class.
Issue Time Tracking
-------------------
Worklog Id: (was: 771034)
Time Spent: 1h 20m (was: 1h 10m)
> Clean up/Fix runtime warning messages in python unit test standard error
> ------------------------------------------------------------------------
>
> Key: BEAM-14474
> URL: https://issues.apache.org/jira/browse/BEAM-14474
> Project: Beam
> Issue Type: Test
> Components: sdk-py-core
> Reporter: Yi Hu
> Priority: P3
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Currently the log of python unit test results contains thousands of lines of
> runtime warning / future warning / deprecation warnings, making trouble
> shooting during development inconvenient. Most of the warning messages are
> not necessary at all and could be suppressed or fixed if possible.
> For example, the most popped message is hundreds of lines of 'RuntimeWarning:
> Mean of empty slice
> return np.nanmean(a, axis, out=out, keepdims=keepdims)'
> raised in dataframe tests, which could be suppressed.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
