[
https://issues.apache.org/jira/browse/BEAM-14334?focusedWorklogId=771175&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-771175
]
ASF GitHub Bot logged work on BEAM-14334:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/22 07:37
Start Date: 17/May/22 07:37
Worklog Time Spent: 10m
Work Description: mosche commented on code in PR #17662:
URL: https://github.com/apache/beam/pull/17662#discussion_r874469763
##########
runners/spark/spark_runner.gradle:
##########
@@ -113,10 +117,6 @@ test {
}
maxParallelForks 4
- useJUnit {
Review Comment:
previously these unit tests were excluded during `test` runs because they
failed. instead these were run as part of `validatesRunnerStreaming`.
I fixed them so they can be run as normal unit tests, so this exclusion
isn't needed any more.
Issue Time Tracking
-------------------
Worklog Id: (was: 771175)
Time Spent: 10h 20m (was: 10h 10m)
> Avoid using forkEvery in Spark runner tests
> -------------------------------------------
>
> Key: BEAM-14334
> URL: https://issues.apache.org/jira/browse/BEAM-14334
> Project: Beam
> Issue Type: Improvement
> Components: runner-spark, testing
> Reporter: Moritz Mack
> Assignee: Moritz Mack
> Priority: P2
> Time Spent: 10h 20m
> Remaining Estimate: 0h
>
> Usage of *{color:#FF0000}forkEvery 1{color}* is typically a strong sign of
> poor quality / bad code and should be avoided:
> * It significantly impacts performance when running tests.
> * And it often hides resource leaks, either in code or worse in the runner
> itself.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
