[ 
https://issues.apache.org/jira/browse/BEAM-11106?focusedWorklogId=772157&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-772157
 ]

ASF GitHub Bot logged work on BEAM-11106:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/May/22 22:14
            Start Date: 18/May/22 22:14
    Worklog Time Spent: 10m 
      Work Description: lostluck commented on code in PR #17703:
URL: https://github.com/apache/beam/pull/17703#discussion_r876423858


##########
sdks/go/pkg/beam/io/rtrackers/growableOffsetrange/growableOffsetrange.go:
##########
@@ -0,0 +1,124 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// Package offsetrange defines a restriction and restriction tracker for offset
+// ranges. An offset range is just a range, with a start and end, that can
+// begin at an offset, and is commonly used to represent byte ranges for files
+// or indices for iterable containers.
+package growableOffsetrange

Review Comment:
   I'd just put this into the offsetrange package. It is an offset range after 
all.
   
   Remember, packages are not supposed to be a single type. They're supposed to 
be everything related to a concept in the application.
   
   This can then turn into a `offsetrange.GrowableRestriction` and 
`offsetrange.GrowableTracker`.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 772157)
    Time Spent: 5.5h  (was: 5h 20m)

> [Go SDK] Truncating SDFs during drain
> -------------------------------------
>
>                 Key: BEAM-11106
>                 URL: https://issues.apache.org/jira/browse/BEAM-11106
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Robert Burke
>            Assignee: Ritesh Ghorse
>            Priority: P3
>             Fix For: 2.39.0
>
>          Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> Allow SDFs to specify a restriction truncation method to permit faster drains.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to