[
https://issues.apache.org/jira/browse/BEAM-14486?focusedWorklogId=772247&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-772247
]
ASF GitHub Bot logged work on BEAM-14486:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/May/22 04:43
Start Date: 19/May/22 04:43
Worklog Time Spent: 10m
Work Description: lostluck opened a new pull request, #17709:
URL: https://github.com/apache/beam/pull/17709
Removes experimental note from the Go SDK's PubSubio and make it clear that
it only works with Dataflow as currently implemented. If that changes, so too
can the documentation.
Fix a behavioral difference with the python implementation, where raw bytes
messages weren't wrapped in messages before writing. They are now wrapped.
Explicitly panic for other PCollection inputs.
Since this only works on dataflow as implemented, these changes have been
manually tested with a modified wordcap that sends data through a PubSub loop
(publishing to the same topic being read from). Each pipeline was then
successfully drained.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
Issue Time Tracking
-------------------
Worklog Id: (was: 772247)
Remaining Estimate: 0h
Time Spent: 10m
> Better document Pubsubio & match Python implementation.
> -------------------------------------------------------
>
> Key: BEAM-14486
> URL: https://issues.apache.org/jira/browse/BEAM-14486
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The pubsub IO has long been marked experimental for the Go SDK.
> It also has implementation deviations from the Python SDK, in that writes are
> not always sending encoded PubsubMessages to the sink.
> These deviations should be corrected, and the usage made clearer.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
