[
https://issues.apache.org/jira/browse/BEAM-14489?focusedWorklogId=772278&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-772278
]
ASF GitHub Bot logged work on BEAM-14489:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/May/22 05:46
Start Date: 19/May/22 05:46
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on PR #17712:
URL: https://github.com/apache/beam/pull/17712#issuecomment-1131234208
#
[Codecov](https://codecov.io/gh/apache/beam/pull/17712?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#17712](https://codecov.io/gh/apache/beam/pull/17712?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(2397980) into
[master](https://codecov.io/gh/apache/beam/commit/6774b747ba42fdc187d4ba8dc34f48a3e1cc9368?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(6774b74) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #17712 +/- ##
=======================================
Coverage 74.00% 74.01%
=======================================
Files 695 695
Lines 91798 91761 -37
=======================================
- Hits 67938 67913 -25
+ Misses 22612 22604 -8
+ Partials 1248 1244 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `50.39% <100.00%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
to find out more.
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/17712?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/go/pkg/beam/io/textio/sdf.go](https://codecov.io/gh/apache/beam/pull/17712/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pby90ZXh0aW8vc2RmLmdv)
| `46.72% <100.00%> (ø)` | |
|
[sdks/go/pkg/beam/io/textio/textio.go](https://codecov.io/gh/apache/beam/pull/17712/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pby90ZXh0aW8vdGV4dGlvLmdv)
| `64.70% <100.00%> (-0.87%)` | :arrow_down: |
|
[...o/pkg/beam/io/rtrackers/offsetrange/offsetrange.go](https://codecov.io/gh/apache/beam/pull/17712/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pby9ydHJhY2tlcnMvb2Zmc2V0cmFuZ2Uvb2Zmc2V0cmFuZ2UuZ28=)
| `75.70% <0.00%> (ø)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/17712?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/17712?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[6774b74...2397980](https://codecov.io/gh/apache/beam/pull/17712?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Issue Time Tracking
-------------------
Worklog Id: (was: 772278)
Time Spent: 20m (was: 10m)
> Make all TextIO SDF.
> --------------------
>
> Key: BEAM-14489
> URL: https://issues.apache.org/jira/browse/BEAM-14489
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P2
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We currently have two kinds of textio.Read an SDF version and a Non SDF
> version. They should be unified (removing the non-SDF one) to avoid confusing
> users.
> Since there are likely a number of various packages using one or the other,
> we will point others to the existing Read calls but mark the SDF ones as
> deprecated. They will not be removed, as that's the Go way.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
