[
https://issues.apache.org/jira/browse/BEAM-14484?focusedWorklogId=772498&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-772498
]
ASF GitHub Bot logged work on BEAM-14484:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/May/22 15:23
Start Date: 19/May/22 15:23
Worklog Time Spent: 10m
Work Description: damccorm commented on code in PR #17716:
URL: https://github.com/apache/beam/pull/17716#discussion_r877206672
##########
sdks/go/pkg/beam/core/runtime/exec/datasource.go:
##########
@@ -348,6 +348,18 @@ func (n *DataSource) makeEncodeElms() func([]*FullValue)
([][]byte, error) {
return encodeElms
}
+func getRTrackerFromRoot(root *FullValue) (sdf.BoundableRTracker, float64,
bool) {
+ tracker, ok :=
root.Elm.(*FullValue).Elm2.(*FullValue).Elm.(sdf.BoundableRTracker)
+ if !ok {
+ return nil, -1.0, false
+ }
+ size, ok := root.Elm2.(float64)
+ if !ok {
Review Comment:
Ah I see - and we need to do the type inference anyways for our return. I'm
not really convinced we need the check, but if we do have it I'd probably make
it an error. We have no way of knowing that this is not a data loss case, so it
doesn't really make sense to me to silently continue.
I don't feel strongly enough about that to block the PR.
Issue Time Tracking
-------------------
Worklog Id: (was: 772498)
Time Spent: 2.5h (was: 2h 20m)
> Improve error message surrounding primary returns in the self-checkpointing
> code
> --------------------------------------------------------------------------------
>
> Key: BEAM-14484
> URL: https://issues.apache.org/jira/browse/BEAM-14484
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Jack McCluskey
> Priority: P1
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> The error message in the Go SDK harness around returned primaries in the
> self-checkpointing code
> ([https://github.com/apache/beam/blob/ea1f292e9cf31fc8c4803b10d811f0d3ee184ae7/sdks/go/pkg/beam/core/runtime/exec/datasource.go#L375)]
> is unclear and should be made more explicit. It should also guide the user
> towards making sure that the restriction behaves properly in the
> self-checkpointing case.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
