[
https://issues.apache.org/jira/browse/BEAM-7070?focusedWorklogId=228853&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-228853
]
ASF GitHub Bot logged work on BEAM-7070:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/19 06:28
Start Date: 17/Apr/19 06:28
Worklog Time Spent: 10m
Work Description: amaliujia commented on pull request #8301: [BEAM-7070]
JOIN condition should accept field access
URL: https://github.com/apache/beam/pull/8301#discussion_r276094918
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamJoinRel.java
##########
@@ -248,16 +250,24 @@ private boolean isSideInputLookupJoin() {
PCollection<Row> leftRows = pinput.get(0);
PCollection<Row> rightRows = pinput.get(1);
+ int leftRowColumnCount = leftRelNode.getRowType().getFieldCount();
+
// extract the join fields
- List<Pair<Integer, Integer>> pairs =
- extractJoinColumns(leftRelNode.getRowType().getFieldCount());
+ List<Pair<RexNode, RexNode>> pairs = extractJoinRexNodes();
// build the extract key type
// the name of the join field is not important
Schema extractKeySchemaLeft =
- pairs.stream().map(pair ->
leftSchema.getField(pair.getKey())).collect(toSchema());
+ pairs.stream()
+ .map(pair -> BeamJoinRel.getFieldBasedOnRexNode(leftSchema,
pair.getKey(), 0))
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 228853)
Time Spent: 1h 50m (was: 1h 40m)
> JOIN condition should accept field access
> -----------------------------------------
>
> Key: BEAM-7070
> URL: https://issues.apache.org/jira/browse/BEAM-7070
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
