[
https://issues.apache.org/jira/browse/BEAM-7005?focusedWorklogId=228941&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-228941
]
ASF GitHub Bot logged work on BEAM-7005:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/19 08:53
Start Date: 17/Apr/19 08:53
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #8247: [BEAM-7005]
Added a set of Jenkins load tests with GBK for Java in streaming mode
URL: https://github.com/apache/beam/pull/8247#discussion_r276139454
##########
File path: .test-infra/jenkins/CommonLoadTestConfiguration.groovy
##########
@@ -0,0 +1,216 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import CommonTestProperties
+
+class CommonLoadTestConfiguration {
Review comment:
I wonder if it would be better if we have the `CommonLoadTestConfiguration`,
streaming testing job and batch testing job in one file? We can create multiple
jobs in one file. They could reuse `CommonLoadTestConfiguration` the same way
but without the need to import it. The config would also remain hidden for the
load tests only - after all we wouldn't want other (non load-test) jobs to be
able to import this. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 228941)
Time Spent: 9h 20m (was: 9h 10m)
> Create GroupByKey streaming load test job for Java SDK
> ------------------------------------------------------
>
> Key: BEAM-7005
> URL: https://issues.apache.org/jira/browse/BEAM-7005
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Michal Walenia
> Assignee: Michal Walenia
> Priority: Minor
> Time Spent: 9h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
