[
https://issues.apache.org/jira/browse/BEAM-14484?focusedWorklogId=772952&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-772952
]
ASF GitHub Bot logged work on BEAM-14484:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/May/22 18:16
Start Date: 20/May/22 18:16
Worklog Time Spent: 10m
Work Description: damccorm commented on code in PR #17724:
URL: https://github.com/apache/beam/pull/17724#discussion_r878410245
##########
sdks/go/pkg/beam/core/sdf/sdf.go:
##########
@@ -88,6 +89,8 @@ type RTracker interface {
// claimed. This method is called by the SDK Harness to validate that a
splittable DoFn has
// correctly processed all work in a restriction before finishing. If
this method still returns
// false after processing, then GetError is expected to return a
non-nil error.
+ //
+ // When called immediately following a checkpointing TrySplit() call,
this should return true.
Review Comment:
```suggestion
// When called immediately following a checkpointing TrySplit() call
(with value 0.0), this
// should return true.
```
##########
sdks/go/pkg/beam/core/sdf/sdf.go:
##########
@@ -73,8 +73,9 @@ type RTracker interface {
// reason), then this function returns nil as the residual.
//
// If the split fraction is 0 (e.g. a self-checkpointing split)
TrySplit() should return either
Review Comment:
```suggestion
// If the split fraction is 0 (e.g. a self-checkpointing split)
TrySplit() should return
```
Issue Time Tracking
-------------------
Worklog Id: (was: 772952)
Time Spent: 7.5h (was: 7h 20m)
> Improve error message surrounding primary returns in the self-checkpointing
> code
> --------------------------------------------------------------------------------
>
> Key: BEAM-14484
> URL: https://issues.apache.org/jira/browse/BEAM-14484
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Jack McCluskey
> Priority: P1
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
> The error message in the Go SDK harness around returned primaries in the
> self-checkpointing code
> ([https://github.com/apache/beam/blob/ea1f292e9cf31fc8c4803b10d811f0d3ee184ae7/sdks/go/pkg/beam/core/runtime/exec/datasource.go#L375)]
> is unclear and should be made more explicit. It should also guide the user
> towards making sure that the restriction behaves properly in the
> self-checkpointing case.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
