[
https://issues.apache.org/jira/browse/BEAM-14494?focusedWorklogId=772989&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-772989
]
ASF GitHub Bot logged work on BEAM-14494:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/May/22 18:56
Start Date: 20/May/22 18:56
Worklog Time Spent: 10m
Work Description: tvalentyn commented on code in PR #17725:
URL: https://github.com/apache/beam/pull/17725#discussion_r878465252
##########
.github/workflows/build_wheels.yml:
##########
@@ -128,7 +128,7 @@ jobs:
run: |
RELEASE_VERSION=${{ steps.get_rc_version.outputs.RELEASE_VERSION }}
RC_NUM=${{ steps.get_rc_version.outputs.RC_NUM }}
- sed -i -e "s/${RELEASE_VERSION}/${RELEASE_VERSION}rc${RC_NUM}/g"
apache_beam/version.py
+ sed -i -e "s/${RELEASE_VERSION}/${RELEASE_VERSION}_rc${RC_NUM}/g"
apache_beam/version.py
Review Comment:
I think we should fix it the other way around, as the release version
follows an established pattern:
https://packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/#standards-compliance-for-interoperability
Issue Time Tracking
-------------------
Worklog Id: (was: 772989)
Time Spent: 0.5h (was: 20m)
> Mismatch between container image tags for RC and SDK expectations
> -----------------------------------------------------------------
>
> Key: BEAM-14494
> URL: https://issues.apache.org/jira/browse/BEAM-14494
> Project: Beam
> Issue Type: Bug
> Components: release
> Reporter: Valentyn Tymofieiev
> Assignee: Yichi Zhang
> Priority: P2
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Beam Portable runner expects:
> INFO:root:Default Python SDK image for environment is
> apache/beam_python3.7_sdk:2.39.0rc2
> However, when building an RC we, build an image
> apache/beam_python3.7_sdk:2.39.0_rc2
> We need to change the tags in the release scripts, at least for Python
> images. Not sure about other languages, likely as well - we need to see what
> runners expect.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
