[
https://issues.apache.org/jira/browse/BEAM-14129?focusedWorklogId=773704&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773704
]
ASF GitHub Bot logged work on BEAM-14129:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/May/22 19:39
Start Date: 23/May/22 19:39
Worklog Time Spent: 10m
Work Description: lukecwik commented on code in PR #17169:
URL: https://github.com/apache/beam/pull/17169#discussion_r879806838
##########
sdks/python/apache_beam/io/gcp/pubsublite/external.py:
##########
@@ -30,8 +30,7 @@
_ReadSchema = typing.NamedTuple(
'_ReadSchema',
- [('subscription_path', str), ('min_bundle_timeout', int),
- ('deduplicate', bool)])
+ [('subscription_path', str), ('deduplicate', bool)])
Review Comment:
```suggestion
```
##########
sdks/python/apache_beam/io/gcp/pubsublite/external.py:
##########
@@ -30,8 +30,7 @@
_ReadSchema = typing.NamedTuple(
'_ReadSchema',
Review Comment:
```suggestion
'_ReadSchema', [('subscription_path', str), ('deduplicate', bool)])
```
##########
sdks/python/apache_beam/io/gcp/pubsublite/external.py:
##########
@@ -79,7 +71,6 @@ def __init__(
NamedTupleBasedPayloadBuilder(
_ReadSchema(
subscription_path=subscription_path,
Review Comment:
```suggestion
subscription_path=subscription_path,
deduplicate=deduplicate)),
```
##########
sdks/python/apache_beam/io/gcp/pubsublite/external.py:
##########
@@ -79,7 +71,6 @@ def __init__(
NamedTupleBasedPayloadBuilder(
_ReadSchema(
subscription_path=subscription_path,
- min_bundle_timeout=min_bundle_timeout,
deduplicate=deduplicate)),
Review Comment:
```suggestion
```
Issue Time Tracking
-------------------
Worklog Id: (was: 773704)
Time Spent: 23.5h (was: 23h 20m)
> Fix issues with Pub/Sub Lite IO at high volumes
> -----------------------------------------------
>
> Key: BEAM-14129
> URL: https://issues.apache.org/jira/browse/BEAM-14129
> Project: Beam
> Issue Type: Task
> Components: io-java-gcp
> Reporter: Daniel Collins
> Assignee: Daniel Collins
> Priority: P1
> Fix For: 2.38.0
>
> Time Spent: 23.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
