[
https://issues.apache.org/jira/browse/BEAM-14499?focusedWorklogId=773710&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773710
]
ASF GitHub Bot logged work on BEAM-14499:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/May/22 19:45
Start Date: 23/May/22 19:45
Worklog Time Spent: 10m
Work Description: damccorm commented on code in PR #17735:
URL: https://github.com/apache/beam/pull/17735#discussion_r879812094
##########
sdks/go/pkg/beam/pardo.go:
##########
@@ -63,7 +65,8 @@ func TryParDo(s Scope, dofn interface{}, col PCollection,
opts ...Option) ([]PCo
return nil, fmt.Errorf("main input is global windowed
in DoFn %v but side input %v is not, cannot map windows correctly. Consider
re-windowing the side input PCollection before use", fn, i)
}
if (sideWfn.Kind == window.GlobalWindows) &&
!sideNode.Bounded() {
- return nil, fmt.Errorf("side input %v is global
windowed in DoFn %v but is unbounded, DoFn will block until end of Global
Window. Consider windowing your unbounded side input PCollection before use",
i, fn)
+ // TODO(BEAM-14501): Replace this warning with an error
return when proper streaming test functions have been added.
+ log.Warnf(context.Background(), "side input %v is
global windowed in DoFn %v but is unbounded, DoFn will block until end of
Global Window. Consider windowing your unbounded side input PCollection before
use", i, fn)
Review Comment:
If we're planning on upgrading this to an error, I would say that as part of
the warning. That saves us the work of needing to do that sort of rollout work
in the future.
Issue Time Tracking
-------------------
Worklog Id: (was: 773710)
Time Spent: 5h 20m (was: 5h 10m)
> TestStream tests are broken after new construction check was added
> ------------------------------------------------------------------
>
> Key: BEAM-14499
> URL: https://issues.apache.org/jira/browse/BEAM-14499
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Jack McCluskey
> Assignee: Jack McCluskey
> Priority: P2
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> The Go SDK's TestStream integration tests are currently failing as a result
> of the restrictions on creating unwindowed, unbounded side inputs being added
> for BEAM-14473. These should be fixed so the Flink PostCommit tests give
> signal again.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
