[ 
https://issues.apache.org/jira/browse/BEAM-14492?focusedWorklogId=774407&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774407
 ]

ASF GitHub Bot logged work on BEAM-14492:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/May/22 08:07
            Start Date: 25/May/22 08:07
    Worklog Time Spent: 10m 
      Work Description: dmvk commented on code in PR #17715:
URL: https://github.com/apache/beam/pull/17715#discussion_r881349101


##########
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPipelineOptions.java:
##########
@@ -285,6 +285,14 @@
 
   void setFasterCopy(Boolean fasterCopy);
 
+  @Description(
+      "Directory containing Flink YAML configuration files. "

Review Comment:
   would be great if we can make it even more explicit that the configuration 
is only applied during JobGraph construction and doesn't affect the cluster 
configuration in any way.
   
   nit: It would be great the description could be a constant that is used for 
both java and portable runner (to make sure these won't diverge by mistake)





Issue Time Tracking
-------------------

    Worklog Id:     (was: 774407)
    Time Spent: 1h 10m  (was: 1h)

> Add possibility to set any flink option into FlinkPipelineOptions
> -----------------------------------------------------------------
>
>                 Key: BEAM-14492
>                 URL: https://issues.apache.org/jira/browse/BEAM-14492
>             Project: Beam
>          Issue Type: New Feature
>          Components: runner-flink
>    Affects Versions: 2.39.0
>            Reporter: Jan Lukavský
>            Assignee: Jan Lukavský
>            Priority: P2
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Sometimes it is necessary to be able to set any flink option via 
> PipelineOptions to the runner - mostly when we submit job from vanilla Java, 
> not being run via {{flink run}}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to