[
https://issues.apache.org/jira/browse/BEAM-14408?focusedWorklogId=775262&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-775262
]
ASF GitHub Bot logged work on BEAM-14408:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/May/22 22:15
Start Date: 26/May/22 22:15
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on code in PR #17771:
URL: https://github.com/apache/beam/pull/17771#discussion_r883122160
##########
sdks/python/apache_beam/typehints/batch.py:
##########
@@ -104,6 +110,12 @@ def __hash__(self) -> int:
class ListBatchConverter(BatchConverter):
+ SAMPLE_FRACTION = 0.2
Review Comment:
Similarly here, this is just an arbitrary sample rate. Should we try harder
to keep this consistent with the reservoir sampling done in `OperationCounters`?
Issue Time Tracking
-------------------
Worklog Id: (was: 775262)
Time Spent: 0.5h (was: 20m)
> batch-consuming DoFns should estimate byte size
> -----------------------------------------------
>
> Key: BEAM-14408
> URL: https://issues.apache.org/jira/browse/BEAM-14408
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
