[ 
https://issues.apache.org/jira/browse/BEAM-14525?focusedWorklogId=775324&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-775324
 ]

ASF GitHub Bot logged work on BEAM-14525:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/May/22 02:53
            Start Date: 27/May/22 02:53
    Worklog Time Spent: 10m 
      Work Description: asf-ci commented on PR #17775:
URL: https://github.com/apache/beam/pull/17775#issuecomment-1139230689

   Can one of the admins verify this patch?




Issue Time Tracking
-------------------

    Worklog Id:     (was: 775324)
    Time Spent: 20m  (was: 10m)

> Unable to find Proto getters in certain cases
> ---------------------------------------------
>
>                 Key: BEAM-14525
>                 URL: https://issues.apache.org/jira/browse/BEAM-14525
>             Project: Beam
>          Issue Type: Bug
>          Components: extensions-java-protobuf
>            Reporter: Balázs Németh
>            Priority: P2
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Proto property name: *item2partner_id* 
> Generated java library method names:
>  * *hasItem2PartnerId*
>  * *getItem2PartnerId*
>  * *setItem2PartnerId*
>  * *clearItem2PartnerId*
> org.apache.beam.sdk.extensions.protobuf.ProtoByteBuddyUtils generated getter 
> name:
>  * *getItem2partnerId*
>  
> Notice the case difference of 'p'. The getter method name creation isn't 
> aligned with protobuf standards.
> See:
>  - 
> [https://github.com/protocolbuffers/protobuf/blob/ec79d0d328c7e6cea15cc27fbeb9b018ca289590/src/google/protobuf/compiler/java/helpers.cc#L246-L248]
>  - 
> [https://github.com/protocolbuffers/protobuf/blob/ec79d0d328c7e6cea15cc27fbeb9b018ca289590/src/google/protobuf/compiler/java/helpers.cc#L173-L208]
>  
> According this logic anything that isn't A-Za-z makes the next character 
> uppercase.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to