[
https://issues.apache.org/jira/browse/BEAM-14513?focusedWorklogId=775491&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-775491
]
ASF GitHub Bot logged work on BEAM-14513:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/May/22 14:29
Start Date: 27/May/22 14:29
Worklog Time Spent: 10m
Work Description: msbukal commented on code in PR #17748:
URL: https://github.com/apache/beam/pull/17748#discussion_r883670923
##########
sdks/go/pkg/beam/io/fhirio/read_test.go:
##########
@@ -0,0 +1,84 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package fhirio
+
+import (
+ "errors"
+ "net/http"
+ "strings"
+ "testing"
+
+ "github.com/apache/beam/sdks/v2/go/pkg/beam/testing/passert"
+ "github.com/apache/beam/sdks/v2/go/pkg/beam/testing/ptest"
+)
+
+func TestRead(t *testing.T) {
+ testCases := []struct {
+ name string
+ client fhirStoreClient
+ containedError string
+ }{
+ {
+ name: "Read Request Failed",
+ client: &fakeFhirStoreClient{
+ fakeReadResources: func(resource string)
(*http.Response, error) {
+ return nil, errors.New("")
+ },
+ },
+ containedError: "Failed to fetch resource",
Review Comment:
I don't see a problem with comparing error strings, in fact frequently find
tests that only check errors are returned but not contents are testing a
different error path than the test name says. Creating custom error types is
probably more elaborate than needed right now. Since we're only checking the
error contains a substring (instead of checking the whole error), I think this
isn't too bad, we should just keep comparing the strings as-is.
Issue Time Tracking
-------------------
Worklog Id: (was: 775491)
Time Spent: 3h (was: 2h 50m)
> Add Read transform and initial HealthcareClient in Go SDK
> ---------------------------------------------------------
>
> Key: BEAM-14513
> URL: https://issues.apache.org/jira/browse/BEAM-14513
> Project: Beam
> Issue Type: Improvement
> Components: io-go-gcp
> Reporter: Lucas Nogueira
> Assignee: Lucas Nogueira
> Priority: P2
> Time Spent: 3h
> Remaining Estimate: 0h
>
> This is the first of many tickets to bring
> [FhirIO|https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java]
> from Java into the Go SDK.
> It consists of:
> * Adding the
> [Read|https://github.com/apache/beam/blob/3e683606d9a03e7da3d37a83eb16c3a6b96068cd/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java#L455]
> transform in Go SDK
> * Adding a basic implementation of the
> [HttpHealthcareClient|https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HttpHealthcareApiClient.java]
> in Go, to be able to authenticate and make the requests needed for the
> transform above.
> Buganizer links:
> - [b/233887489|https://b.corp.google.com/issues/233887489].
> - [b/204355275|https://buganizer.corp.google.com/issues/204355275].
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
