[
https://issues.apache.org/jira/browse/BEAM-6908?focusedWorklogId=229486&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-229486
]
ASF GitHub Bot logged work on BEAM-6908:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/19 23:08
Start Date: 17/Apr/19 23:08
Worklog Time Spent: 10m
Work Description: udim commented on pull request #8324: [BEAM-6908]
Support Python3 performance benchmarks - part 2
URL: https://github.com/apache/beam/pull/8324#discussion_r276459804
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1722,6 +1740,45 @@ class BeamModulePlugin implements Plugin<Project> {
outputs.files project.fileTree(dir:
"${pythonRootDir}/target/.tox/${tox_env}/log/")
}
}
+
+ // Run single or a set of integration tests with provided test options
and pipeline options.
+ project.ext.enablePythonPerformanceTest = {
+
+ // Use the implicit it parameter of the closure to handle zero
argument or one argument map calls.
+ // See: http://groovy-lang.org/closures.html#implicit-it
+ def config = it ? it as PythonPerformanceTestConfiguration : new
PythonPerformanceTestConfiguration()
+
+ project.task('integrationTest') {
+ dependsOn 'installGcpTest'
+ dependsOn 'sdist'
+
+ doLast {
+ def argMap = [:]
+
+ // Build test options that configures test environment and
framework
+ def testOptions = []
Review comment:
No basicTestOpts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 229486)
Time Spent: 50m (was: 40m)
> Add Python3 performance benchmarks
> ----------------------------------
>
> Key: BEAM-6908
> URL: https://issues.apache.org/jira/browse/BEAM-6908
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Mark Liu
> Assignee: Mark Liu
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Similar to
> [beam_PerformanceTests_Python|https://builds.apache.org/view/A-D/view/Beam/view/PerformanceTests/job/beam_PerformanceTests_Python/],
> we want to have a Python3 benchmark running on Jenkins to detect performance
> regression during code adoption.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
