[
https://issues.apache.org/jira/browse/BEAM-14541?focusedWorklogId=776599&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-776599
]
ASF GitHub Bot logged work on BEAM-14541:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jun/22 00:11
Start Date: 01/Jun/22 00:11
Worklog Time Spent: 10m
Work Description: yixiaoshen opened a new pull request, #17789:
URL: https://github.com/apache/beam/pull/17789
Current code does the conversion by first manually calculating the millis
from a proto Timestamp with `long millis = time.getSeconds() * 1000 +
time.getNanos() / 1000`, but 1 millisecond = 1,000,000 nanoseconds instead of
1,000. This PR changes to use proto Timestamps util class to do the conversion
in order to be less prone to such mistakes.
R: @chamikaramj
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
Issue Time Tracking
-------------------
Worklog Id: (was: 776599)
Remaining Estimate: 0h
Time Spent: 10m
> Timestamp value conversion in Cloud Datastore connector is wrong
> ----------------------------------------------------------------
>
> Key: BEAM-14541
> URL: https://issues.apache.org/jira/browse/BEAM-14541
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp
> Reporter: Yixiao Shen
> Assignee: Yixiao Shen
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Code in org.apache.beam.sdk.io.gcp.datastore.EntityToRow class:
> {code:java}
> com.google.protobuf.Timestamp time = val.getTimestampValue();
> long millis = time.getSeconds() * 1000 + time.getNanos() / 1000;
> return Instant.ofEpochMilli(millis).toDateTime();{code}
> 1 millisecond = 1,000,000 nanoseconds
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
