[
https://issues.apache.org/jira/browse/BEAM-14470?focusedWorklogId=777031&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777031
]
ASF GitHub Bot logged work on BEAM-14470:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jun/22 17:21
Start Date: 01/Jun/22 17:21
Worklog Time Spent: 10m
Work Description: lostluck commented on PR #17790:
URL: https://github.com/apache/beam/pull/17790#issuecomment-1143907081
As discussed offline, we decided to completely remove the method restriction
entirely. While this may make things a little harder for novices, it will make
things harder for novices with typos in the optional methods. These should be
detectable by users via testing however.
Unfortunately there's no good way of validating this on our end short of
doing some sort of typo/proximity algorithm, which is likely more trouble than
better documentation and clearer examples, hence the initial strict approach.
Issue Time Tracking
-------------------
Worklog Id: (was: 777031)
Time Spent: 2h (was: 1h 50m)
> Optimize load tests w/generic registrations
> -------------------------------------------
>
> Key: BEAM-14470
> URL: https://issues.apache.org/jira/browse/BEAM-14470
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go, testing
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P2
> Fix For: 2.40.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> With Generic Registration available, a way to indicate the value would be via
> the load tests.
> In particular the following tests should be optimized:
> http://metrics.beam.apache.org/d/fK0U4JqWz/cogbk-load-tests?orgId=1&var-processingType=batch&var-sdk=go
> http://metrics.beam.apache.org/d/WNzYt13Zk/combine-load-tests?orgId=1&var-processingType=batch&var-sdk=go
> http://metrics.beam.apache.org/d/UYZ-oJ3Zk/gbk-load-tests?orgId=1&var-processingType=batch&var-sdk=go
> http://metrics.beam.apache.org/d/MOi-kf3Zk/pardo-load-tests?orgId=1&var-processingType=batch&var-sdk=go
> http://metrics.beam.apache.org/d/-E9aGlFGk/side-input-load-tests?orgId=1&var-processingType=batch&var-sdk=go
> Benchmarks show reduce per call overhead by about ~300ns per parameter in the
> invoked user function, just like the code generated, and any improvement
> should be reflected by the load test graphs going forward.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
