[
https://issues.apache.org/jira/browse/BEAM-4461?focusedWorklogId=229530&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-229530
]
ASF GitHub Bot logged work on BEAM-4461:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Apr/19 01:40
Start Date: 18/Apr/19 01:40
Worklog Time Spent: 10m
Work Description: reuvenlax commented on issue #8273: [BEAM-4461] A
transform to perform binary joins of PCollections with schemas
URL: https://github.com/apache/beam/pull/8273#issuecomment-484323080
Ah sorry I missed that! I'll send another PR to fix the lhs parameter.
On Wed, Apr 17, 2019 at 5:04 PM Yueyang Qiu <[email protected]>
wrote:
> *@robinyqiu* commented on this pull request.
> ------------------------------
>
> In
>
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/Join.java
> <https://github.com/apache/beam/pull/8273#discussion_r276477268>:
>
> > + /**
> + * Perform a natural join between the PCollections. The fields are
expected to exist in both
> + * PCollections
> + */
> + public Inner<LhsT, RhsT> using(FieldAccessDescriptor
fieldAccessDescriptor) {
> + return new Inner<>(
> + joinType, rhs,
FieldsEqual.left(fieldAccessDescriptor).right(fieldAccessDescriptor));
> + }
> +
> + /** Join the PCollections using the provided predicate. */
> + public Inner<LhsT, RhsT> on(FieldsEqual.Inner predicate) {
> + return new Inner<>(joinType, rhs, predicate);
> + }
> +
> + @Override
> + public PCollection<Row> expand(PCollection lhs) {
>
> I was asking about the input parameter PCollection lhs, not the return
> type.
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/8273#discussion_r276477268>, or mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/AFAYJVKAK4MQ4IJNN5MMZCTPQ63KRANCNFSM4HFB7O6A>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 229530)
Time Spent: 28h 10m (was: 28h)
> Create a library of useful transforms that use schemas
> ------------------------------------------------------
>
> Key: BEAM-4461
> URL: https://issues.apache.org/jira/browse/BEAM-4461
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Labels: triaged
> Time Spent: 28h 10m
> Remaining Estimate: 0h
>
> e.g. JoinBy(fields). Project, Filter, etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
