[jira] [Work logged] (BEAM-14545) Optimize copies in dataflow v1 shuffle reader

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/BEAM-14545?focusedWorklogId=777037&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777037
 ]

ASF GitHub Bot logged work on BEAM-14545:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Jun/22 17:26
            Start Date: 01/Jun/22 17:26
    Worklog Time Spent: 10m 
      Work Description: steveniemitz opened a new pull request, #17802:
URL: https://github.com/apache/beam/pull/17802

   The current implementation for reading from shuffle copies byte[]s out of 
the larger buffer returned from reading from shuffle.  This changes it to 
instead wrap the large buffer with ByteStrings, avoiding copying them again.
   
   R: @lukecwik 
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   
    - [x] [**Choose 
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and 
mention them in a comment (`R: @username`).
    - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue, if applicable. This will automatically link the pull request to the 
issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [x] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more 
tips on [how to make review process 
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit 
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   
------------------------------------------------------------------------------------------------
   [![Build python source distribution and 
wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python 
tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java 
tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more 
information about GitHub Actions CI.
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 777037)
    Remaining Estimate: 0h
            Time Spent: 10m

> Optimize copies in dataflow v1 shuffle reader
> ---------------------------------------------
>
>                 Key: BEAM-14545
>                 URL: https://issues.apache.org/jira/browse/BEAM-14545
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-dataflow
>            Reporter: Steve Niemitz
>            Assignee: Steve Niemitz
>            Priority: P2
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The dataflow v1 shuffle reader unnecessarily copies the byte[] read from 
> shuffle, we could use something like ByteString to instead "slice" the buffer 
> into pieces and avoid a few copies.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)