[
https://issues.apache.org/jira/browse/BEAM-14536?focusedWorklogId=777051&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777051
]
ASF GitHub Bot logged work on BEAM-14536:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jun/22 17:41
Start Date: 01/Jun/22 17:41
Worklog Time Spent: 10m
Work Description: lostluck commented on code in PR #17782:
URL: https://github.com/apache/beam/pull/17782#discussion_r887134011
##########
sdks/go/pkg/beam/core/runtime/exec/sdf.go:
##########
@@ -678,10 +678,6 @@ func (n *ProcessSizedElementsAndRestrictions) Checkpoint()
([]*FullValue, error)
return nil, addContext(err)
}
- if !n.rt.IsDone() {
- return nil, addContext(errors.Errorf("Primary restriction %#v
is not done. Check that the RTracker's TrySplit() at fraction 0.0 returns a
completed primary restriction", n.rt))
- }
Review Comment:
Glad this was caught. This is basically the only place we can tell the user
if they've implemented the SDF incorrectly in some fashion. While it's later
than ideal (at execution, rather than construction time), a hard abort is
preferable to other correctness or dataloss issues.
Issue Time Tracking
-------------------
Worklog Id: (was: 777051)
Time Spent: 3h 10m (was: 3h)
> Offsetrange tracker panics when splitting at 0.0 without claiming work
> ----------------------------------------------------------------------
>
> Key: BEAM-14536
> URL: https://issues.apache.org/jira/browse/BEAM-14536
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Reporter: Danny McCormick
> Assignee: Danny McCormick
> Priority: P2
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Right now, if you try to call TrySplit on an offsetrange restriction with a
> fraction of 0.0 and without first claiming work, it sets the primary
> restriction to \{Start, Start-1}. This causes newSplitResult to panic -
> https://github.com/apache/beam/blob/ff39fcb5229b15140e41a61bd09f7d590730e93a/sdks/go/pkg/beam/core/runtime/exec/sdf.go#L859
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
