Robert Burke created BEAM-14546:
-----------------------------------

             Summary: [Go SDK] passert.Count succeeds for empty PCollections.
                 Key: BEAM-14546
                 URL: https://issues.apache.org/jira/browse/BEAM-14546
             Project: Beam
          Issue Type: Improvement
          Components: sdk-go
            Reporter: Robert Burke


https://github.com/apache/beam/blob/sdks/v2.39.0/sdks/go/pkg/beam/testing/passert/count.go#L28

Since it's using a Combine to do the count, it never executes for empty 
Pcollections, and is unable to fail.

The fix is: when count > 0, plumb the pcollection through as a side input to a 
DoFn that requires the side input to be non-empty. This would catch the empty 
PCollection case.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to