[jira] [Work logged] (BEAM-10976) Enable Bundle Finalization in Go SDK

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/BEAM-10976?focusedWorklogId=777544&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777544
 ]

ASF GitHub Bot logged work on BEAM-10976:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Jun/22 13:36
            Start Date: 02/Jun/22 13:36
    Worklog Time Spent: 10m 
      Work Description: damccorm opened a new pull request, #17811:
URL: https://github.com/apache/beam/pull/17811

   Right now, running an SDF with a BundleFinalizer blows up with errors: 
`panic: runtime error: invalid memory address or nil pointer dereference 
goroutine 100`. It was working fine on non-SDFs.
   
   I was able to repro - failing pipeline:
   
   <img width="342" alt="image" 
src="https://user-images.githubusercontent.com/42773683/171641509-b3213dcb-1974-4aef-89b5-c9bd27867f11.png";>
   
   And after the fix the same pipeline succeeds:
   
   <img width="331" alt="image" 
src="https://user-images.githubusercontent.com/42773683/171641554-d787e1bc-061d-4d67-b604-d0e6b0781829.png";>
   
   I also verified that non-SDFs still don't have any issues
   
   This also fixes a doc bug with the programming guide which had the 
parameters misordered.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   
    - [ ] [**Choose 
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and 
mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue, if applicable. This will automatically link the pull request to the 
issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more 
tips on [how to make review process 
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit 
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   
------------------------------------------------------------------------------------------------
   [![Build python source distribution and 
wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python 
tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java 
tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more 
information about GitHub Actions CI.
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 777544)
    Time Spent: 14.5h  (was: 14h 20m)

> Enable Bundle Finalization in Go SDK
> ------------------------------------
>
>                 Key: BEAM-10976
>                 URL: https://issues.apache.org/jira/browse/BEAM-10976
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Robert Burke
>            Assignee: Danny McCormick
>            Priority: P3
>             Fix For: 2.39.0
>
>          Time Spent: 14.5h
>  Remaining Estimate: 0h
>
> Eg. to support acking pubsub/kafka messages as processed after the results 
> have been properly committed by the runner.
> Note, that due to BEAM-10959 that when implementing this, an instruction must 
> remain "active" until it's finalization occurs as well. Specifically, we 
> should probably keep another map around for "to be finalized" process bundle 
> instructions so we can return the appropriate "empty" response and not 
> accidently evict them from the nearly equivalent inactive state until after 
> finalization.
> [https://s.apache.org/beam-finalizing-bundles]
>  
> (To be updated once [https://github.com/apache/beam/pull/13160] is merged and 
> the programming guide updated with SDF content.)
> See also Java and Python approaches
> https://beam.apache.org/documentation/programming-guide/#bundle-finalization



--
This message was sent by Atlassian Jira
(v8.20.7#820007)