[
https://issues.apache.org/jira/browse/BEAM-14504?focusedWorklogId=777725&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777725
]
ASF GitHub Bot logged work on BEAM-14504:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jun/22 17:09
Start Date: 02/Jun/22 17:09
Worklog Time Spent: 10m
Work Description: fbeevikm commented on code in PR #17741:
URL: https://github.com/apache/beam/pull/17741#discussion_r888192448
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirBundleResponseCoder.java:
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.gcp.healthcare;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import org.apache.beam.sdk.coders.CustomCoder;
+import org.apache.beam.sdk.coders.NullableCoder;
+import org.apache.beam.sdk.coders.StringUtf8Coder;
+
+public class FhirBundleResponseCoder extends CustomCoder<FhirBundleResponse> {
+ private static final NullableCoder<String> STRING_CODER =
NullableCoder.of(StringUtf8Coder.of());
+ private final FhirBundleParameterCoder fhirBundleParameterCoder =
FhirBundleParameterCoder.of();
+
+ public static FhirBundleResponseCoder of() {
+ return new FhirBundleResponseCoder();
+ }
+
+ @Override
+ public void encode(FhirBundleResponse value, OutputStream outStream) throws
IOException {
+ fhirBundleParameterCoder.encode(value.getFhirBundleParameter(), outStream);
+ STRING_CODER.encode(value.getResponse(), outStream);
+ }
+
+ @Override
+ public FhirBundleResponse decode(InputStream inStream) throws IOException {
+ FhirBundleParameter fhirBundleParameter =
fhirBundleParameterCoder.decode(inStream);
+ String response = STRING_CODER.decode(inStream);
+ return FhirBundleResponse.of(fhirBundleParameter, response);
Review Comment:
done
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirBundleParameterCoder.java:
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.gcp.healthcare;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import org.apache.beam.sdk.coders.CustomCoder;
+import org.apache.beam.sdk.coders.NullableCoder;
+import org.apache.beam.sdk.coders.StringUtf8Coder;
+
+/** Coder for {@link FhirBundleParameter}. */
+public class FhirBundleParameterCoder extends CustomCoder<FhirBundleParameter>
{
+ private static final NullableCoder<String> STRING_CODER =
NullableCoder.of(StringUtf8Coder.of());
+
+ public static FhirBundleParameterCoder of() {
+ return new FhirBundleParameterCoder();
+ }
+
+ @Override
+ public void encode(FhirBundleParameter value, OutputStream outStream) throws
IOException {
+ STRING_CODER.encode(value.getMetadata(), outStream);
+ STRING_CODER.encode(value.getBundle(), outStream);
+ }
+
+ @Override
+ public FhirBundleParameter decode(InputStream inStream) throws IOException {
+ String metadata = STRING_CODER.decode(inStream);
+ String bundle = STRING_CODER.decode(inStream);
+ return FhirBundleParameter.of(metadata, bundle);
+ }
+}
Review Comment:
done
Issue Time Tracking
-------------------
Worklog Id: (was: 777725)
Time Spent: 6h 10m (was: 6h)
> Add support for including addittional parameters to executebundle method in
> fhirio.
> -----------------------------------------------------------------------------------
>
> Key: BEAM-14504
> URL: https://issues.apache.org/jira/browse/BEAM-14504
> Project: Beam
> Issue Type: Improvement
> Components: io-java-healthcare
> Reporter: Fathima Mohammed
> Assignee: Fathima Mohammed
> Priority: P2
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> Add FhirBundleWithMetadata in executebundles method so that we can pass
> additional information like message id.
> FhirBundleWithMetadata represents a FHIR bundle, with it's metadata (eg. Hl7
> messageId) to be executed on the intermediate FHIR store.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
