[
https://issues.apache.org/jira/browse/BEAM-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17547046#comment-17547046
]
Kenneth Knowles commented on BEAM-4103:
---------------------------------------
This issue has been migrated to https://github.com/apache/beam/issues/18838
> Invert JavaNature configuration
> -------------------------------
>
> Key: BEAM-4103
> URL: https://issues.apache.org/jira/browse/BEAM-4103
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Kenneth Knowles
> Priority: P3
> Labels: gradle
>
> Today the applyJavaNature method demonstrates a significant programming and
> build config anti-pattern: one giant method with unclear/no spec and some
> flags to tweak what it does, that can only really be understood by reading
> its full code.
> Instead, best practice would be to separate the functionality controlled by
> each flag into a block that a module can call. It is not wrong to pass
> configuration parameters, but in this case that's not really what is going on.
> Since the flags are "on by default" and serve to suppress things like
> findbugs, this just means breaking out the findbugs into a separate bit. We
> can always also have a convenience three-liner that calls the basics, calls
> findbugs, etc.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
