[
https://issues.apache.org/jira/browse/BEAM-6682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17547501#comment-17547501
]
Kenneth Knowles commented on BEAM-6682:
---------------------------------------
This issue has been migrated to https://github.com/apache/beam/issues/19262
> [GoSDK] There should be a combineFn unit tester that validates lifting.
> -----------------------------------------------------------------------
>
> Key: BEAM-6682
> URL: https://issues.apache.org/jira/browse/BEAM-6682
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Robert Burke
> Priority: P3
>
> The Go direct runner doesn't handle combiner lifting, which means combiners
> aren't validated whether they support lifting correctly or not. It should be
> possible for the ptest package to simulate combiner lifting, and actuate the
> lifecycle methods, or for the direct runner to be re-written to handle
> combiner lifting as a configuration option. This would make it easier to
> avoid mistakes and typos when handling lifecycle methods for CombineFns.
>
> In particular look at
> [https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/transforms/top/top_test.go]
> which could be much simpler for users implementing combiners and avoid the
> manual scaffolding.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
