[
https://issues.apache.org/jira/browse/BEAM-8486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17548278#comment-17548278
]
Danny McCormick commented on BEAM-8486:
---------------------------------------
This issue has been migrated to https://github.com/apache/beam/issues/19920
> Reference to ParallelBundleManager attr "_skip_registration" should be
> "_registered"
> ------------------------------------------------------------------------------------
>
> Key: BEAM-8486
> URL: https://issues.apache.org/jira/browse/BEAM-8486
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Priority: P3
>
> It appears there was a mistake in the multiprocess refactor of the
> BundleManager. I came across this issue while getting mypy type analysis
> setup (score one for static type checking!)
>
> The offending line is here:
> https://github.com/apache/beam/blob/8d2997f8d7ad84649b8ecb2f7e2ca2eceb91b6d0/sdks/python/apache_beam/runners/portability/fn_api_runner.py#L933
> I think it should be using "_registered", as seen here:
> https://github.com/apache/beam/blob/8d2997f8d7ad84649b8ecb2f7e2ca2eceb91b6d0/sdks/python/apache_beam/runners/portability/fn_api_runner.py#L1909
> I can easily change the attribute name, but presumably this will change the
> behavior. Hopefully for the better, but I don't know enough to say.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
