[ 
https://issues.apache.org/jira/browse/BEAM-10785?focusedWorklogId=778427&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778427
 ]

ASF GitHub Bot logged work on BEAM-10785:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Jun/22 06:58
            Start Date: 05/Jun/22 06:58
    Worklog Time Spent: 10m 
      Work Description: harrydrippin commented on PR #17518:
URL: https://github.com/apache/beam/pull/17518#issuecomment-1146753160

   @pabloem Just for sure, do you mean it is good if I apply the change to the 
original `RowAsDictJsonCoder` implementation just like my custom one? (adding 
`ensure_ascii=False` on the `json.dumps`)
   
   I will submit another PR for this if you confirm. Thanks!




Issue Time Tracking
-------------------

    Worklog Id:     (was: 778427)
    Time Spent: 2h 20m  (was: 2h 10m)

> Support for coder argument in WriteToBigQuery
> ---------------------------------------------
>
>                 Key: BEAM-10785
>                 URL: https://issues.apache.org/jira/browse/BEAM-10785
>             Project: Beam
>          Issue Type: Bug
>          Components: io-py-gcp
>            Reporter: Nakamura Yu
>            Assignee: Seunghwan Hong
>            Priority: P1
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> When using WriteToBigQuery to transfer data to BigQuery, non-ascii characters 
> are replaced with replacement characters.
> This was due to the RowAsDictJsonCoder being set as the coder for the 
> BigQueryBatchFileLoads called inside WriteToBigQuery.
> I want to add coder to the argument of WriteToBigQuery so that I can set a 
> coder other than RowAsDictJsonCoder.
> If no problem, I will create a Pull Request next weekend.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to