[
https://issues.apache.org/jira/browse/BEAM-2939?focusedWorklogId=233614&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-233614
]
ASF GitHub Bot logged work on BEAM-2939:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Apr/19 15:47
Start Date: 26/Apr/19 15:47
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #8412: [BEAM-2939]
Support SDF expansion in the Flink runner.
URL: https://github.com/apache/beam/pull/8412#discussion_r278995246
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner_transforms.py
##########
@@ -788,14 +799,34 @@ def make_stage(base_stage, transform_id,
extra_must_follow=()):
inputs=dict(transform.inputs, **{main_input_tag: paired_pcoll_id}),
outputs={'out': split_pcoll_id})
+ if common_urns.composites.RESHUFFLE.urn in context.known_runner_urns:
+ reshuffle_pcoll_id = copy_like(
+ context.components.pcollections,
+ main_input_id,
+ '_reshuffle',
+ coder_id=sized_coder_id)
+ reshuffle_transform_id = copy_like(
+ context.components.transforms,
+ transform,
+ unique_name=transform.unique_name + '/Reshuffle',
+ urn=common_urns.composites.RESHUFFLE.urn,
+ payload=b'',
+ inputs=dict(transform.inputs, **{main_input_tag:
split_pcoll_id}),
+ outputs={'out': reshuffle_pcoll_id})
+ yield make_stage(stage, reshuffle_transform_id)
+ else:
+ reshuffle_pcoll_id = split_pcoll_id
+ reshuffle_transform_id = None
Review comment:
Isn't Reshuffle necessary to balance split work evenly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 233614)
Time Spent: 17h 40m (was: 17.5h)
> Fn API SDF support
> ------------------
>
> Key: BEAM-2939
> URL: https://issues.apache.org/jira/browse/BEAM-2939
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Henning Rohde
> Assignee: Luke Cwik
> Priority: Major
> Labels: portability, triaged
> Time Spent: 17h 40m
> Remaining Estimate: 0h
>
> The Fn API should support streaming SDF. Detailed design TBD.
> Once design is ready, expand subtasks similarly to BEAM-2822.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
