[
https://issues.apache.org/jira/browse/BEAM-4543?focusedWorklogId=233718&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-233718
]
ASF GitHub Bot logged work on BEAM-4543:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Apr/19 19:55
Start Date: 26/Apr/19 19:55
Worklog Time Spent: 10m
Work Description: udim commented on pull request #8262: [BEAM-4543]
Python Datastore IO using google-cloud-datastore
URL: https://github.com/apache/beam/pull/8262#discussion_r279083805
##########
File path: sdks/python/apache_beam/io/gcp/datastore/v1/datastoreio.py
##########
@@ -45,6 +50,10 @@
try:
from google.cloud.proto.datastore.v1 import datastore_pb2
from googledatastore import helper as datastore_helper
+ logging.warning(
+ 'Using deprecated Datastore client.\n'
+ 'This client will be removed in the next Beam major release.\n'
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 233718)
Time Spent: 5.5h (was: 5h 20m)
> Remove dependency on googledatastore in favor of google-cloud-datastore.
> ------------------------------------------------------------------------
>
> Key: BEAM-4543
> URL: https://issues.apache.org/jira/browse/BEAM-4543
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Udi Meiri
> Priority: Minor
> Labels: triaged
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> apache-beam[gcp] package depends [1] on googledatastore package [2]. We
> should replace this dependency with google-cloud-datastore [3] which is
> officially supported, has better release cadence and also has Python 3
> support.
> [1]
> https://github.com/apache/beam/blob/fad655462f8fadfdfaab0b7a09cab538f076f94e/sdks/python/setup.py#L126
> [2] [https://pypi.org/project/googledatastore/]
> [3] [https://pypi.org/project/google-cloud-datastore/]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
