[
https://issues.apache.org/jira/browse/BEAM-3344?focusedWorklogId=233750&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-233750
]
ASF GitHub Bot logged work on BEAM-3344:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Apr/19 21:01
Start Date: 26/Apr/19 21:01
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #8302: [BEAM-3344]
Changes for serialize/deserialize PipelineOptions via jackson in DirectRunner
URL: https://github.com/apache/beam/pull/8302#discussion_r279100423
##########
File path:
runners/direct-java/src/test/java/org/apache/beam/runners/direct/DirectRunnerTest.java
##########
@@ -581,6 +584,39 @@ public void testUnencodableOutputFromUnboundedRead() {
p.run();
}
+ /**
+ * Tests that {@link DirectRunner#fromOptions(PipelineOptions)} drops {@link
PipelineOptions}
+ * marked with {@link JsonIgnore} fields.
+ */
+ @Test
+ public void testFromOptionsIfIgnoredFieldsGettingDropped() {
+ PipelineOptions options =
Review comment:
```suggestion
TestSerializationOfOptions options =
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 233750)
Time Spent: 2h 50m (was: 2h 40m)
> DirectRunner should serialize/deserialize PipelineOptions via Jackson to
> simulate what remote execution runners do
> ------------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-3344
> URL: https://issues.apache.org/jira/browse/BEAM-3344
> Project: Beam
> Issue Type: Bug
> Components: runner-direct
> Reporter: Luke Cwik
> Assignee: Madhusudhan Reddy Vennapusa
> Priority: Minor
> Labels: newbie, starter, triaged
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> DirectRunner currently doesn't drop PipelineOptions marked with `@JsonIgnore`
> like other runners such as Flink and Spark and hence when a pipeline is tried
> with a runner that executes locally it seemingly works but then when executed
> remotely it fails because certain PipelineOptions are unavailable during
> execution.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
