[
https://issues.apache.org/jira/browse/BEAM-4374?focusedWorklogId=234879&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234879
]
ASF GitHub Bot logged work on BEAM-4374:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Apr/19 20:16
Start Date: 29/Apr/19 20:16
Worklog Time Spent: 10m
Work Description: Ardagan commented on pull request #8062: [BEAM-4374]
Emit SampledByteCount distribution tuple system metric from Python SDK
(@Ardagan helped contribute)
URL: https://github.com/apache/beam/pull/8062#discussion_r279521187
##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -675,14 +675,15 @@ def monitoring_infos(self):
infos_list = list(all_monitoring_infos_dict.values())
- def inject_pcollection_into_element_count(monitoring_info):
+ def inject_pcollection(monitoring_info):
"""
If provided metric is element count metric:
Finds relevant transform output info in current process_bundle_descriptor
and adds tag with PCOLLECTION_LABEL and pcollection_id into monitoring
info.
"""
- if monitoring_info.urn == monitoring_infos.ELEMENT_COUNT_URN:
+ if monitoring_info.urn in set([monitoring_infos.ELEMENT_COUNT_URN,
Review comment:
This set can be extracted to final field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 234879)
Time Spent: 15h 50m (was: 15h 40m)
> Update existing metrics in the FN API to use new Metric Schema
> --------------------------------------------------------------
>
> Key: BEAM-4374
> URL: https://issues.apache.org/jira/browse/BEAM-4374
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Alex Amato
> Priority: Major
> Time Spent: 15h 50m
> Remaining Estimate: 0h
>
> Update existing metrics to use the new proto and cataloging schema defined in:
> [_https://s.apache.org/beam-fn-api-metrics_]
> * Check in new protos
> * Define catalog file for metrics
> * Port existing metrics to use this new format, based on catalog
> names+metadata
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
