[
https://issues.apache.org/jira/browse/BEAM-6844?focusedWorklogId=234897&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234897
]
ASF GitHub Bot logged work on BEAM-6844:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Apr/19 20:54
Start Date: 29/Apr/19 20:54
Worklog Time Spent: 10m
Work Description: ajamato commented on pull request #8038: [BEAM-6844]
Add MetricResultMatcher verification for user metrics, GBK element count, and
process time to an integration test.
URL: https://github.com/apache/beam/pull/8038#discussion_r279535467
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_metrics.py
##########
@@ -148,18 +175,13 @@ def _populate_metric_results(self, response):
metrics_by_name[metric_key][tentative_or_committed] = metric
# Now we create the MetricResult elements.
- result = []
for metric_key, metric in iteritems(metrics_by_name):
attempted = self._get_metric_value(metric['tentative'])
committed = self._get_metric_value(metric['committed'])
- if attempted is None or committed is None:
- continue
result.append(MetricResult(metric_key,
Review comment:
no need for that. Since the URNs do this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 234897)
Time Spent: 40m (was: 0.5h)
> Metrics tests for Portable metrics
> ----------------------------------
>
> Key: BEAM-6844
> URL: https://issues.apache.org/jira/browse/BEAM-6844
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-harness, sdk-py-harness
> Reporter: Pablo Estrada
> Assignee: Alex Amato
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
