[
https://issues.apache.org/jira/browse/BEAM-1542?focusedWorklogId=234918&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234918
]
ASF GitHub Bot logged work on BEAM-1542:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Apr/19 21:26
Start Date: 29/Apr/19 21:26
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #8404: [BEAM-1542]
Add a possibility to pass a project that hosts Cloud Spanner instance.
URL: https://github.com/apache/beam/pull/8404#discussion_r279546111
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerReadIT.java
##########
@@ -61,6 +62,12 @@
/** Pipeline options for this test. */
public interface SpannerTestPipelineOptions extends TestPipelineOptions {
+ @Description("Project that hosts Spanner instance")
+ @Nullable
+ String getInstanceProjectId();
Review comment:
As long as the PipelineOption interface isn't being registered via a
ServiceLoader automatically, a call to PipelineOptionsFactory.resetCache()
after each test in a `@TearDown` method will remove the pollution of the
namespace. If it is being registered via serviceloader then people have to be
careful around name choices/classpaths.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 234918)
Time Spent: 1h (was: 50m)
> Need Source/Sink for Spanner
> ----------------------------
>
> Key: BEAM-1542
> URL: https://issues.apache.org/jira/browse/BEAM-1542
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp
> Reporter: Guy Molinari
> Assignee: Mairbek Khadikov
> Priority: Major
> Fix For: 2.1.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Is there a source/sink for Spanner in the works? If not I would gladly give
> this a shot.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
