[
https://issues.apache.org/jira/browse/BEAM-6138?focusedWorklogId=235444&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-235444
]
ASF GitHub Bot logged work on BEAM-6138:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Apr/19 17:59
Start Date: 30/Apr/19 17:59
Worklog Time Spent: 10m
Work Description: ajamato commented on pull request #8280: [BEAM-6138]
Update java SDK to report user distribution tuple metrics over the FN API
URL: https://github.com/apache/beam/pull/8280#discussion_r279858897
##########
File path:
runners/core-java/src/test/java/org/apache/beam/runners/core/metrics/MetricsContainerImplTest.java
##########
@@ -182,6 +182,38 @@ public void
testMonitoringInfosArePopulatedForUserCounters() {
assertThat(actualMonitoringInfos, containsInAnyOrder(builder1.build(),
builder2.build()));
}
+ @Test
+ public void testMonitoringInfosArePopulatedForUserDistributions() {
+ MetricsContainerImpl testObject = new MetricsContainerImpl("step1");
+ DistributionCell c1 = testObject.getDistribution(MetricName.named("ns",
"name1"));
+ DistributionCell c2 = testObject.getDistribution(MetricName.named("ns",
"name2"));
Review comment:
Okay, I added a test for this case as well. But this required adding the
MonitoringInfoSpec for SampledByteCount, which I was going to do in this PR
which is queued up after this one. But I have pulled it into this PR.
https://github.com/apache/beam/pull/8416/files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 235444)
Time Spent: 11h 20m (was: 11h 10m)
> Add User Metric Support to Java SDK
> -----------------------------------
>
> Key: BEAM-6138
> URL: https://issues.apache.org/jira/browse/BEAM-6138
> Project: Beam
> Issue Type: New Feature
> Components: java-fn-execution
> Reporter: Alex Amato
> Assignee: Alex Amato
> Priority: Major
> Labels: triaged
> Time Spent: 11h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
