[
https://issues.apache.org/jira/browse/BEAM-7193?focusedWorklogId=235585&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-235585
]
ASF GitHub Bot logged work on BEAM-7193:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Apr/19 23:08
Start Date: 30/Apr/19 23:08
Worklog Time Spent: 10m
Work Description: adude3141 commented on issue #8445: [BEAM-7193]
ParDoLifecycleTest: remove duplicated inner class
URL: https://github.com/apache/beam/pull/8445#issuecomment-488147223
Apart from the method names, they are identical. I.e. difference are
```diff
1c1
< private static class CallSequenceEnforcingDoFn<T> extends DoFn<T, T> {
---
> private static class CallSequenceEnforcingFn<T> extends DoFn<T, T> {
8c8
< public void setup() {
---
> public void before() {
17c17
< public void startBundle() {
---
> public void begin() {
28c28
< public void processElement(ProcessContext c) throws Exception {
---
> public void process(ProcessContext c) throws Exception {
38c38
< public void finishBundle() {
---
> public void end() {
49c49
< public void teardown() {
---
> public void after() {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 235585)
Time Spent: 20m (was: 10m)
> ParDoLifecycleTest: duplicated inner class
> ------------------------------------------
>
> Key: BEAM-7193
> URL: https://issues.apache.org/jira/browse/BEAM-7193
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Michael Luckey
> Assignee: Michael Luckey
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> After migration from OldDoFn and later refactoring, ParDoLifecycleTest has 2
> nearly identical DoFn implementations. Code should be consolidated to use
> only one
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
